GNUstep / Android compatibility changes #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when building for non-Apple platforms, e.g. for Android using GNUstep/libdispatch.
Required when building using GNUstep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small changes needed to build YapDatabase with the GNUstep Android toolchain:
__bridgeannotations in various places (mainly to convert from/tovoidpointers) – these seem to be optional in these places with Apple’s toolchains (not sure why), but also make the code more explicit.OS_OBJECT_USE_OBJC, i.e. when libdispatch objects are not bridged to ObjC objects.isCancelledgetter for NSProgress’cancelledproperty – both getters are supported on Apple platforms, but GNUstep only defines this one getter.As most of these are fairly small changes I thought you might be willing to upstream these, but if not we’re also happy to keep using our branch.
We’ve been running YapDatabase with these changes on Android for a couple of months now for our app (currently in beta), and it’s been working great.